Frontend
inspector-list in attik-frontend/src/components/conditions/templatingData.ts (and any agreement-specific templating path that reuses it).GET inspection/slug/:slug may omit populate=inspectors.Backend
attik-backend should either populate inspector docs for agreement rendering or expose a stable display-name helper (e.g. inspectorDisplayName pattern referenced in existing notes).attik-frontend/src/components/conditions/templatingData.ts (key inspector-list)attik-backend/src/routes/ (inspection slug route—locate inspection/slug handler)Users have reported that the inspector list merge field on agreements sometimes shows the word "undefined" in the client agreement view, even when inspectors are assigned to the job. They expect agreement text to show the actual inspector names (or a sensible fallback), especially in the client portal when reviewing or signing.
Why it matters: Wrong or broken text on legal agreements undermines trust and forces staff to fix documents manually.
Engineering scope (for implementation):
GET inspection/slug/:slug without populate=inspectors, so _inspectorId is often raw ids, not populated inspector docs.inspector-list in templatingData.ts uses only inspector.name; string ids yield template literal "undefined". Align with backend inspectorDisplayName (firstName/lastName, then name, then email) and/or ensure portal inspection fetch populates inspectors when rendering agreements.Please authenticate to join the conversation.
Code Review
Main App
26 days ago
Linear
Get notified by email when there are changes.
Code Review
Main App
26 days ago
Linear
Get notified by email when there are changes.